On Mon, 9 Nov 2026 18:14:35 GMT, Christopher Schnick <[email protected]> 
wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassWindowEventHandler.java
>>  line 69:
>> 
>>> 67:             case WindowEvent.MAXIMIZE:
>>> 68:                 listener.changedIconified(false);
>>> 69:                 listener.changedMaximized(true);
>> 
>> If I understand this correctly, the following sequence will happen: 
>> 1. iconfied state
>> 2. listener will be nulled because we `hide()` the stage
>> 3. we still change / deliver the maxiimized state to the stage that 
>> otherwise has no listener anymore
>> 
>> I don't think this is a problem. But I still want to bring this up -- does 
>> this make sense / no harm in doing that?
>> Otherwise we need to null check every second `changeXYZ` call.
>
> I haven't seen issues caused by that. The listener impl still keeps track of 
> the changed state, so I would say it is more correct to still call the 
> listener. It makes a difference if you then reshow the stage again. If the 2. 
> listener call would not be done, the state would not be up to date

Agree, makes sense!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2364#discussion_r4516316993

Reply via email to