> The second split PR of the CSS saga™.
> 
> Some pre-existing issues were found once again in 
> https://github.com/openjdk/jfx/pull/2225, which were made more obvious with 
> the changes.
> 
> When using a relative property like `-fx-padding: 1em;` with a font-size set 
> like this: `-fx-font-size: 20px;`, it may not correctly reset the padding as 
> soon as the font size is removed.
> 
> In this example, the padding is 20, and when removed, it should reset to 0.
> 
> Problem in code is simple: Two different code locations are similar, but not 
> completely, leading to a bug just with relative properties, but not otherwise.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marius Hanl has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains three additional commits since 
the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jfx into 
8393844-Relative-CSS-property-may-not-be-correctly-reset-sometimes
 - Merge branch 'master' of https://github.com/openjdk/jfx into 
8393844-Relative-CSS-property-may-not-be-correctly-reset-sometimes
 - 8393844: Relative CSS property may not be correctly reset sometimes

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2337/files
  - new: https://git.openjdk.org/jfx/pull/2337/files/ffcd4e4b..3f688253

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2337&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2337&range=01-02

  Stats: 811 lines in 26 files changed: 472 ins; 252 del; 87 mod
  Patch: https://git.openjdk.org/jfx/pull/2337.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2337/head:pull/2337

PR: https://git.openjdk.org/jfx/pull/2337

Reply via email to