On Thu, 12 Nov 2026 19:34:40 GMT, Andy Goryachev <[email protected]> wrote:

>> Marius Hanl has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - revert to previous behavior
>>  - notifyParentsOfInvalidatedCSS() is there is a Scene
>
> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line 
> 960:
> 
>> 958:             Entry<CssMetaData, CalculatedValue> entry = it.next();
>> 959:             CssMetaData cssMetaData = entry.getKey();
>> 960:             if (cssMetaData != 
>> TransitionDefinitionCssMetaData.getInstance() && 
>> !styleables.contains(cssMetaData)) {
> 
> unlikely but legitimate scenario: when a custom skin provides a different 
> metadata for the same control property.  this check seems to discard the 
> original reset entry.

I reverted this to the previous behavior.

I don't think this corner case is worth the effort right now. It's a pretty 
unusual API scenario, so I'd rather not address it here and keep the scope on 
the main use case. We can come back to it if it turns out to matter in practice.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2366#discussion_r4555829015

Reply via email to