On Fri, 13 Nov 2026 16:34:49 GMT, Kevin Rushforth <[email protected]> wrote:

>> Fixes exporting of the `CodeArea` font to RTF and HTML.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/HtmlStyledOutput.java
>  line 369:
> 
>> 367:         wr.write("<head>\n");
>> 368:         wr.write("<meta charset=\"utf-8\">\n");
>> 369:         if (font != null) {
> 
> I see that this unconditionally writes the font information to the HTML 
> header, even when `inlineStyles` is true. Is this intentional? Would it be 
> better to move this underneath the `if (!inlineStyles)` check? If you did 
> that, you'd need to emit the font information with each inline style.

these cases are mutually exclusive, and impossible to encounter even with a 
custom model, so should be ok.  and, if both are emitted, there is no harm.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2369#discussion_r4566481660

Reply via email to