On Mon, 16 Nov 2026 19:26:24 GMT, Jose Pereda <[email protected]> wrote:
>> tests/system/src/test/java/test/javafx/stage/CloseWindowTest.java line 113:
>>
>>> 111: childStage.setScene(new Scene(new StackPane(new
>>> Label("Child stage")), 200, 120));
>>> 112:
>>> 113: childStage.setOnHidden(_ -> doneLatch.countDown());
>>
>> I am afraid this did not fix the test: this event is sent before
>> `requestFocus()` on L74. The native focus events might come after
>> runAndWait() so the tests won't catch the NPE.
>>
>> maybe use the fact that focus is restored as a completion criteria?
>
>> this did not fix the test
>
> does it fail for you? It passes for me on Windows and macOS
this is a code review comment, I have not run the test(s) yet. my pet LLM
basically tells us that the test may not catch the NPE because it ends
prematurely.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2373#discussion_r4590452303