On Mon, 16 Nov 2026 16:11:03 GMT, Andy Goryachev <[email protected]> wrote:

>> The `HeaderBar` layout container has no default style class. However, in 
>> contrast to the other `Pane`-based layout containers, it has a clear 
>> semantic role, and should therefore have the default style class 
>> `header-bar` so it can be easily targeted by themes.
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 
> 2668:
> 
>> 2666:       </tr>
>> 2667:       <tr>
>> 2668:         <th colspan="4" class="parents" scope="row">Also has all 
>> properties of <a href="#region">Region</a></th>
> 
> unlike `Region`, `minHeight` follows the `systemMinHeightProperty` once 
> attached to a `Stage`.  should this behavior be mentioned here?

I don't think we should repeat the specification of `-fx-min-height` here, as 
it is already specified in `Region` and we don't repeat a specification 
anywhere else in this document. It also doesn't seem like cssref.html contains 
the entire specification of each property.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2371#discussion_r4601908787

Reply via email to