Thanks. Unfortunately I had to combine them in one PR because the two
patches are interdependent and I can't do much about that (GML3.2 must
also support complex features). I have added test cases for all new
functionality.
I have noticed in the meantime however there was already an old PR for
GML3.2 support that never got approved :/
Kind Regards
Niels
On 22-07-18 20:02, OpenLayers Dev wrote:
(I am not a member of the OL development team)
Please go ahead with creating your pull requests; the OL development
team will be automatically notified of your pull request. 2 separate
pull requests might be a good plan.
-jeff
On 2018-07-20 9:25 AM, Niels Charlier via OpenLayers Dev wrote:
Hello,
I have written two patches for open layers:
* support for GML 3.2
* support for parsing complex features
I was wondering if the community would be interested in me
contributing these to the codebase.
The first one simply adds a whole new format, so it is a very safe
addition.
The second one replaces an existing function:
ol.format.GMLBase.prototype.readFeaturesInternal
however my implementation of this function is a generalisation of the
current implementation,
and it is thus fully backwards compatible with how simple features
are parsed now.
I don't know if there is some kind of testing mechanism in place to
proof my changes don't break anything.
I could make one or two PRs on github, let me know i there is
interest and what I need to do in order to get it approved, .
Kind Regards
Niels
--
You received this message because you are subscribed to the Google Groups
"OpenLayers Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/openlayers-dev.
To view this discussion on the web visit
https://groups.google.com/d/msgid/openlayers-dev/7b41a7ea-9fa9-6e4f-e1ff-b32298ac394e%40scitus.be.
For more options, visit https://groups.google.com/d/optout.
