Hello Lutz, Thanks for your interest in contributing to the library. I left a comment on the pull request about rebasing your branch to get the fix for the dependency issue.
It might also be good to provide some information on the pull request for people who don’t have any prior exposure to IIIF. I’m curious, for example, how common IIIF-based tile services might be (I haven’t looked, maybe this info is easy to find from the pull request or original issue). >From the comments on the pull request, it sounds like a new version of the spec is underway. Do you anticipate being available to continue making contributions as changes to the spec or issues with the implementation are found? I don’t have any specific concerns with IIIF or your contribution, but know that it is important to have people willing to help maintain the code for a contribution to be more of an asset that a liability. Thanks again for your interest in contributing. Tim On Mon, Apr 29, 2019 at 1:10 AM OpenLayers Dev on behalf of Lutz Helm < [email protected]> wrote: > Dear list, > > I have two questions: > > 1. Circle CI fails for PR 9430 [1] but I don't see how the error is > related to any changes from the pull request: > > npm ERR! path /home/circleci/repo/node_modules/ol-mapbox-style > npm ERR! code EISGIT > npm ERR! git /home/circleci/repo/node_modules/ol-mapbox-style: > Appears to be a git repo or submodule. > npm ERR! git /home/circleci/repo/node_modules/ol-mapbox-style > npm ERR! git Refusing to remove it. Update manually, > npm ERR! git or move it out of the way first. > > Maybe somebody has a hint? > > 2. Is there any chance that this pull request might be accepted? I know > that 1600 added lines at once might take a while to review; I just want > to know if there's an interest to have a IIIF Image API tile source in > OpenLayers at all. > > All the best, > Lutz > > [1] https://github.com/openlayers/openlayers/pull/9430 > > -- > You received this message because you are subscribed to the Google Groups > "OpenLayers Dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/openlayers-dev. > To view this discussion on the web visit > https://groups.google.com/d/msgid/openlayers-dev/f9774c75-ac97-8063-c464-0e94c7a7d1bd%40ub.uni-leipzig.de > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OpenLayers Dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/openlayers-dev. To view this discussion on the web visit https://groups.google.com/d/msgid/openlayers-dev/CAKdrn%2BeudvGtQWWKRrzVfgVsHKaS%3DefPU8ta-K0UisRW7LKENA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
