Hi Bart, I updated the ticket with new patch with tests included: http://trac.osgeo.org/openlayers/ticket/3053
So please let me know what you think about it when you find time. Thank you. Regards, Ivan On Tue, Mar 1, 2011 at 10:12 AM, Bart van den Eijnden (OSGIS) <bart...@osgis.nl> wrote: > Hi Andrea, > > sure it's all about finding the time to review. > > I had just had a quick look, and adding a few testcases (function with > params, nested functions) would really help to move things forward. So if > you guys can do that, I'll have a look at it. > > Best regards, > Bart > >> On Fri, Feb 18, 2011 at 8:57 AM, Ivan Grcic >> <ivan.gr...@geo-solutions.it>wrote: >> >>> Hi, >>> >>> I would like to know if anyone else maybe took a look at the proposal >>> for Geoserver function support. >>> >>> We've tested it with requests similar to the ones described in the >>> blog post: >>> http://geo-solutions.blogspot.com/2011/02/developer-corner-cross-layer-filtering.html >>> , >>> and they work just fine. >>> >>> Also, all filter tests ran without problems. As we got some funding >>> for this improvements we would like to have this in included in OL >>> Should I provide some tests for the example requests along with the >>> patch, so we could move on with commit? >>> >>> >> Hi all, >> I'm wondering if we are missing some specific step to get the patch >> committed. >> Are we missing docs, tests, anything? >> Or is it just a matter of waiting for someone to find time to review the >> patch? >> >> Cheers >> Andrea >> >> -- >> ------------------------------------------------------- >> Ing. Andrea Aime >> GeoSolutions S.A.S. >> Tech lead >> >> Via Poggio alle Viti 1187 >> 55054 Massarosa (LU) >> Italy >> >> phone: +39 0584 962313 >> fax: +39 0584 962313 >> mob: +39 333 8128928 >> >> http://www.geo-solutions.it >> http://geo-solutions.blogspot.com/ >> http://www.youtube.com/user/GeoSolutionsIT >> http://www.linkedin.com/in/andreaaime >> http://twitter.com/geowolf >> >> ------------------------------------------------------- >> _______________________________________________ >> Dev mailing list >> d...@lists.osgeo.org >> http://lists.osgeo.org/mailman/listinfo/openlayers-dev >> > > > -- ------------------------------------------------------- Ivan Grcic GeoSolutions S.A.S. Software Engineer Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 962313 mob: +39 328 0559267 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://twitter.com/geosolutions_it http://www.youtube.com/user/GeoSolutionsIT ------------------------------------------------------- _______________________________________________ Dev mailing list d...@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/openlayers-dev