Hi guys, Please consider adding comments to a ticket [1] already open on the subject.
Thanks, Pierre [1] http://trac.osgeo.org/openlayers/ticket/1421 On Mon, Dec 20, 2010 at 11:55 AM, Andreas Hocevar <[email protected]> wrote: > Hi Marc, > > thanks for your efforts on this! > > Unit test coverage of the renderers is relatively poor. We mostly rely on > acceptance tests. For this fix, the important test would be that > examples/graphic-names.html works correctly. > > Regards, > Andreas. > > On Dec 17, 2010, at 22:40 , Marc Jansen wrote: > >> Hi Andreas, >> >> thanks for your fast response. Please find comments inline. >> >> >> Am 17.12.2010 13:49, schrieb Andreas Hocevar: >>> Hi, >>> >>> I just played around with this a bit, and if you set this.supportUse to >>> false in the initialize method, it will work. >>> >> >> I can confirm that rendering still works in my Firefox 3.6.13, Opera 10.62 >> and Google Chrome 8.0.552.224. >> >> (Opera does not interpret Ctrl as intended, though: It seems to enlarge the >> SVG-Elements, but it does so with supportUse as well and even if the >> vector-features are plain circles This could be a separate ticket, I guess. >> And I have no Opera 11 to test) >> >>> So in case you want to contribute a fix, and if this change doesn't break >>> Opera or other non-webkit browsers, I'd suggest removing the use-defs way >>> of working with graphicSymbols from Renderer.SVG entirely. >> >> I'd gladly provide a patch if others don't disagree or step up first... but >> I won't have time until monday. I'll leave a note in the files that the >> usage of <use> was once implemented but lead to problems. >> >> I currently cannot imagine a way to implement a specific test-case showing >> the (soon-to-be) fixed bug. Can anyone point me the right direction? >> >> Regards, >> Marc >> >> >>> Regards, >>> Andreas. >>> >>> On Dec 17, 2010, at 12:58 , Marc Jansen wrote: >>> >>>> Hi list, >>>> >>>> I've run into a strange issue present even in the trunk of OpenLayers: >>>> >>>> If you have a vector-feature that is rendered with a graphicName (to have >>>> a rectangle or triangle visualisation) and a select control working on the >>>> feature's layer, if you click on the feature (selection control is active) >>>> and have Ctrl pressed on the keyboard, a new browser window opens with an >>>> URL like >>>> "http://openlayers.org/dev/examples/select-feature.html#OpenLayers.Layer.Vector_39-triangle";. >>>> I see this behaviour in Firefox 3.6.13 on Ubuntu 10.10. >>>> >>>> The vector-SVG is rendered like this: >>>> <use id="OpenLayers.Geometry.Point_180" cx="173.80000305175895" >>>> cy="112.36666870117206" r="1" href="#OpenLayers.Layer.Vector_39-triangle" >>>> width="36" height="36" x="155.80000305175895" y="94.36666870117206" >>>> fill="blue" fill-opacity="0.4" stroke="blue" stroke-opacity="1" >>>> stroke-width="1.6666666666666667" stroke-linecap="round" >>>> stroke-linejoin="round" stroke-dasharray="none" >>>> pointer-events="visiblePainted" cursor="pointer"/> >>>> >>>> and a symbol definition of >>>> >>>> <defs id="OpenLayers.Layer.Vector_39_defs"><symbol >>>> id="OpenLayers.Layer.Vector_39-triangle" viewBox="-10 -10 30 30"><polygon >>>> points="0,10 10,10 5,0 0,10"/></symbol></defs> >>>> >>>> You can experience the behaviour by visiting: >>>> >>>> http://openlayers.org/dev/examples/select-feature.html >>>> >>>> and running this inside Firebugs console, after rendering is done: >>>> OpenLayers.Feature.Vector.style['default']['graphicName'] = "triangle"; >>>> >>>> Select the "draw a point" radio button, draw a point on the map, and >>>> select the "select feature (0 features selected)" radiobutton, uncheck the >>>> checkbox "select features in a box". >>>> >>>> Now hold down Ctrl and click on the feature: In my browser a new window is >>>> opened. >>>> >>>> Do you have an idea about how to fix this? >>>> >>>> Best regards and thanks in advance, >>>> Marc >>>> >>>> >>>> >>>> _______________________________________________ >>>> Users mailing list >>>> [email protected] >>>> http://lists.osgeo.org/mailman/listinfo/openlayers-users >>> >>> >> >> _______________________________________________ >> Users mailing list >> [email protected] >> http://lists.osgeo.org/mailman/listinfo/openlayers-users > > > > -- > Andreas Hocevar > OpenGeo - http://opengeo.org/ > Expert service straight from the developers. > > _______________________________________________ > Users mailing list > [email protected] > http://lists.osgeo.org/mailman/listinfo/openlayers-users > -- Pierre GIRAUD Géomaticien, Analyste Camptocamp France SAS Savoie Technolac, BP 352 73377 Le Bourget du Lac, Cedex Tel : 00 33 4 79 44 44 93 Mail : [email protected] http://www.camptocamp.com _______________________________________________ Users mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/openlayers-users
