Jan Synacek wrote: > Howard Chu <[email protected]> writes: > >> Jan Synacek wrote: >>> Howard Chu <[email protected]> writes: >>> >>>> [email protected] wrote: >>>>> Full_Name: Jan Synacek >>>>> Version: master >>>>> OS: GNU/Linux >>>>> URL: >>>>> https://jsynacek.fedorapeople.org/openldap/jsynacek-20150415-back-perl-correctly-convert-perlModuleConfig.patch >>>>> Submission from: (NULL) (213.175.37.10) >>>>> >>>>> >>>>> When using the perl backend, slaptest doesn't convert perlModuleConfig >>>>> lines >>>>> from slapd.conf to slapd.d. >>>>> >>>>> A simple reproducer can be found at >>>>> https://jsynacek.fedorapeople.org/openldap/back-perl.sh >>>>> >>>>> >>>> Thanks, added to git master >>> >>> I misunderstood the semantics of perlModuleConfig when given multiple >>> arguments, so the patch isn't quite correct. I'm sorry for the >>> confusion. The fix can be found at: >>> >>> URL: >>> https://jsynacek.fedorapeople.org/openldap/jsynacek-20150424-More-for-ITS-8105.patch >>> >>> Please note that I'm not aware of any internal functions that I can use >>> to flatten a list of strings. If there are some, or if there is a better >>> way to fix the issue, please advice, I'll simplify the patch. >>> >> Hi Jan, there's no need to muck with the list of strings, just use >> c->line instead of c->argv. > > Thank you for your advice! I've simplified the patch (url stays the same).
Looks OK. One minor nit - we discourage using strlen() (or most of the libc str* functions, really). We particularly discourage runtime calculations on compile-time constants (including string constants) - use the STRLENOF() macro instead. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
