https://bugs.openldap.org/show_bug.cgi?id=10140
--- Comment #2 from Howard Chu <[email protected]> --- In the manpage, incorrect grammar: s/include fractional/includes fractional/ In logging.c: Related symbols should all have the same prefix. RFC3339_UTC should be LFMT_RFC3339_UTC. In this chunk - whitespace is misaligned. @@ -68,6 +70,10 @@ static char logpaths[2][MAXPATHLEN]; static int logpathlen; #define SYSLOG_STAMP "Mmm dd hh:mm:ss" +#define RFC3339_STAMP "YYYY-mm-ddTHH:MM:SS.ffffffZ" +#define Tfrac_sz sizeof( "ffffffZ" ) +#define TS "%05x" +#define TSf "%06ldZ" void slap_debug_print( const char *data ) In this chunk @@ -150,9 +155,18 @@ slap_debug_print( const char *data ) + snprintf( strchr( ptr, '.' ) + 1, Tfrac_sz, TSf, Tfrac ); The format is constant width, you should be using ptr+[a constant] instead of strchr( ptr, '.' ) - you should already know where the '.' is. This chunk @@ -162,8 +176,8 @@ slap_debug_print( const char *data ) Doesn't belong in the patch at all. -- You are receiving this mail because: You are on the CC list for the issue.
