masar...@aero.polimi.it wrote: >> h...@openldap.org writes: >>> backend.c 1.412 -> 1.413 >>> ITS#6393 syncrepl internal connids are now <= -1000 >> >> backend.c: 'op->o_connid <= -1000' is wrong. o_connid is unsigned long, >> so this is compiled as 'op->o_connid <= (unsigned long) -1000'. > > Right. Also, since o_connid is unsigned long, -1000-rid is a valid connid. > > Perhaps, a char in the Connection structure, or yet another value in some > bitmask would be better.
Except that doesn't help the issue with syncrepl and slap_graduate_commit_csn(). Another suggestion is to reserve connids 0-999 for syncrepl, and start the real connections at 1000. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
