Howard Chu wrote: > [email protected] wrote: >> Version 2... >> >> Part 3 of 3 of this patch with the request changes to options.c >> is now available for review. The full details are located here: >> >> http://cr.opensolaris.org/~djl/openldap-patch3/ >> >> The revised patch has been updated to include all changes as on >> 10-14-10AM >> >> including the commit of: >> Modified Files: >> cyrus.c 1.159 -> 1.160 >> >> >> The only file modified between the first and second version of this patch >> was options.c > > Looking at the patch to abandon.c, first chunk > > http://cr.opensolaris.org/~djl/openldap-patch3/webrev/libraries/libldap/abandon.c.udiff.html > > it looks like you'll deadlock on the ld_req_mutex, based on the preceding > comment. I.e., you should not be using LDAP_NEXT_MSGID() here.
Never mind, I forgot that LDAP_NEXT_MSGID uses its own msgid mutex now. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
