(ITS#6932) Strange assert()s

[h . b . furuseth]

Full_Name: Hallvard B Furuseth
Version: master, 2.4.24
OS: 
URL: 
Submission from: (NULL) (129.240.6.233)
Submitted by: hallvard


Klocwork reports a number of strange assert()s, typically
assert(function parameter != NULL) after dereferencing it.
Also some pointless ones, like
     if (ptr->foo) { bar = ptr; assert(bar != NULL); }

I'll move these, along with some not found by Klocwork.  At the same
time, I'll change some nearby code to use alredy-computed values, e.g.
        be = op->o_bd;
        bi = op->o_bd->bd_info;   can become  bi = be->bd_info;