Send openlmi-reviews mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of openlmi-reviews digest..."
Today's Topics:
1. Re: Review Request 859: [1/1] logicalfile: ignore some key
properties (Michal Minar)
2. Re: Review Request 854: [1/1] Account: Added QA test for
account provider. (Robin Hack)
3. Re: Review Request 854: [1/1] Account: Added QA test for
account provider. (Robin Hack)
4. Re: Review Request 859: [1/1] logicalfile: ignore some key
properties (Jan Synacek)
5. Re: Review Request 854: [1/1] Account: Added QA test for
account provider. (Robin Hack)
6. Re: Review Request 854: [1/1] Account: Added QA test for
account provider. (Michal Minar)
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/859/#review1177
-----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Sept. 13, 2013, 11:31 a.m., Jan Synacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/859/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 11:31 a.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> logicalfile: ignore some key properties
>
> CIM_LogicalFile and CIM_UnixFile have some key properties that are not
> needed when calling GetInstance(). On Linux systems, all is needed to
> get information about a file is its path. Type of the filesystem that
> the file resides on and the file type itself are not needed. In fact,
> it's not desirable to require those when querying remote systems.
>
> Ignore FSCreationClassName, FSName, LFCreationClassName and
> CreationClassName.
>
> This commit reverts most of the functionality of commit
> 5c3e1a6203e495bec37acd8c3731ca41377beb94.
>
>
> Diffs
> -----
>
> src/logicalfile/LMI_DirectoryContainsFileProvider.c
> 753cb00d184a71bbaa3a3d63883110480750d8d9
> src/logicalfile/LMI_FileIdentityProvider.c
> 7ada7873c0b90f88bcbf5b3ba1a44aa704c713e4
> src/logicalfile/LMI_RootDirectoryProvider.c
> 2be709f0d0a0ca50271508dffe67bbfc357cc710
> src/logicalfile/LMI_UnixFileProvider.c
> 5da5bb0a471228653fabc30c5a7793c526ebaff3
> src/logicalfile/file.h b7ecb53cf43ee2f290c5bbdf091165c81b86ac2d
> src/logicalfile/file.c ca0d9f4e88d1b4b78ee7104eb88f676ab30535af
> src/logicalfile/test/test_basic.py fbcf6d57829d35e134cfdedab9501043fd3c372a
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/859/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Synacek
>
>
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 7:27 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Added QA test for account provider.
Diffs (updated)
-----
src/account/test/testAccount.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
Testing
-------
Thanks,
Robin Hack
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1178
-----------------------------------------------------------
src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment728>
User really exists after this call?
Assert missing.
src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment729>
We need separate test case for deleteing user and group... because we need
map this cases to tcms when test will be parametrized.
src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment730>
What is this magic numbers?
- Robin Hack
On Sept. 16, 2013, 7:27 a.m., Robin Hack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/854/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 7:27 a.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Account: Added QA test for account provider.
>
>
> Diffs
> -----
>
> src/account/test/testAccount.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robin Hack
>
>
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/859/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 10:08 a.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
logicalfile: ignore some key properties
CIM_LogicalFile and CIM_UnixFile have some key properties that are not
needed when calling GetInstance(). On Linux systems, all is needed to
get information about a file is its path. Type of the filesystem that
the file resides on and the file type itself are not needed. In fact,
it's not desirable to require those when querying remote systems.
Ignore FSCreationClassName, FSName, LFCreationClassName and
CreationClassName.
This commit reverts most of the functionality of commit
5c3e1a6203e495bec37acd8c3731ca41377beb94.
Diffs
-----
src/logicalfile/LMI_DirectoryContainsFileProvider.c
753cb00d184a71bbaa3a3d63883110480750d8d9
src/logicalfile/LMI_FileIdentityProvider.c
7ada7873c0b90f88bcbf5b3ba1a44aa704c713e4
src/logicalfile/LMI_RootDirectoryProvider.c
2be709f0d0a0ca50271508dffe67bbfc357cc710
src/logicalfile/LMI_UnixFileProvider.c
5da5bb0a471228653fabc30c5a7793c526ebaff3
src/logicalfile/file.h b7ecb53cf43ee2f290c5bbdf091165c81b86ac2d
src/logicalfile/file.c ca0d9f4e88d1b4b78ee7104eb88f676ab30535af
src/logicalfile/test/test_basic.py fbcf6d57829d35e134cfdedab9501043fd3c372a
Diff: http://reviewboard-openlmi.rhcloud.com/r/859/diff/
Testing
-------
Thanks,
Jan Synacek
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 8:57 a.m.)
Review request for OpenLMI Developers.
Changes
-------
Qa test from psklenar.
Repository: openlmi-providers
Description
-------
Account: Added QA test for account provider.
Diffs (updated)
-----
src/account/test/testAccount.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
Testing
-------
Thanks,
Robin Hack
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1179
-----------------------------------------------------------
src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment734>
Magic numbers.
src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment732>
Test for the inverse set of characters would be nice. This asserts, that
*one char* usernames are accepted.
src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment731>
These magic numbers are not well readable. Maybe you could use something
like:
badchar = [chr(i) for i in xrange(0, 128) if chr(i) not in
set(string.ascii_letters + string.digits + '$_')]
src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment733>
If an assertion fails, examiner has to test each character from the badchar
set until he finds out, which one caused it. I'd recommend add some description
string like:
self.assertEqual(user.rval, -1, 'account with invalid username "%s"
created')
- Michal Minar
On Sept. 16, 2013, 8:57 a.m., Robin Hack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/854/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 8:57 a.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Account: Added QA test for account provider.
>
>
> Diffs
> -----
>
> src/account/test/testAccount.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Robin Hack
>
>
--- End Message ---
_______________________________________________
openlmi-reviews mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
_______________________________________________
openlmi-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/openlmi-devel
