Send openlmi-reviews mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of openlmi-reviews digest..."
Today's Topics:
1. Review Request 892: [1/1] account: Fix removing member of
group (Roman Rakus)
2. Re: Review Request 892: [1/1] account: Fix removing member
of group (Radek Novacek)
3. Re: Review Request 892: [1/1] account: Fix removing member
of group (Roman Rakus)
4. Review Request 893: lmishell, quicker associators' traversal
(Peter Hatina)
5. Re: Review Request 893: lmishell, quicker associators'
traversal (Ales Ledvinka)
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/892/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
account: Fix removing member of group
Signed-off-by: Roman Rakus <[email protected]>
Diffs
-----
src/account/LMI_MemberOfGroupProvider.c
4e27def36727ba1a88a6b03438eaa4d80cc36cfc
Diff: http://reviewboard-openlmi.rhcloud.com/r/892/diff/
Testing
-------
Thanks,
Roman Rakus
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/892/#review1238
-----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On Sept. 26, 2013, 3:04 p.m., Roman Rakus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/892/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2013, 3:04 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> account: Fix removing member of group
>
> Signed-off-by: Roman Rakus <[email protected]>
>
>
> Diffs
> -----
>
> src/account/LMI_MemberOfGroupProvider.c
> 4e27def36727ba1a88a6b03438eaa4d80cc36cfc
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/892/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roman Rakus
>
>
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/892/
-----------------------------------------------------------
(Updated Sept. 26, 2013, 1:20 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
account: Fix removing member of group
Signed-off-by: Roman Rakus <[email protected]>
Diffs
-----
src/account/LMI_MemberOfGroupProvider.c
4e27def36727ba1a88a6b03438eaa4d80cc36cfc
Diff: http://reviewboard-openlmi.rhcloud.com/r/892/diff/
Testing
-------
Thanks,
Roman Rakus
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/893/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
This patch introduces lmi_associators() function, which should speed up
associations traversal by pulling all the instances referenced by association
class.
Diffs
-----
cli/lmi/shell/LMIConsole.py bebcce353c9547a9d7ed1c5f0031319e1876b29a
cli/lmi/shell/LMIUtil.py 94f38b4ffedc286e3ac407085b66ad278ed1bcda
Diff: http://reviewboard-openlmi.rhcloud.com/r/893/diff/
Testing
-------
Example of usage:
c = connect(...)
assoc_class_list = [
c.root.cimv2.CIM_BasedOn,
c.root.cimv2.LMI_PhysicalMemoryContainer,
c.root.cimv2.LMI_SystemStorageDevice,
]
for tpl in lmi_associators(assoc_class_list):
print " <-> ".join([get_instance_id(x) for x in tpl])
Output:
/dev/disk/by-uuid/fc6b795d-8722-4222-9252-3cfb3b704dd3 <-> /dev/vda
/dev/disk/by-uuid/09331a46-7876-46de-b9f9-496fc3ff5870 <-> /dev/vda
/dev/disk/by-id/dm-name-volgroup1-lvol0 <->
/dev/disk/by-id/ata-QEMU_HARDDISK_QM00005
/dev/disk/by-id/dm-name-volgroup1-lvol0 <->
/dev/disk/by-id/ata-QEMU_HARDDISK_QM00007
LMI:LMI_MemoryPhysicalPackage:0 <-> LMI:LMI_PhysicalMemory:0
rawhide <-> /dev/disk/by-id/ata-QEMU_HARDDISK_QM00005
rawhide <-> /dev/disk/by-id/ata-QEMU_HARDDISK_QM00007
rawhide <-> /dev/vda
rawhide <-> /dev/disk/by-uuid/fc6b795d-8722-4222-9252-3cfb3b704dd3
rawhide <-> /dev/disk/by-uuid/09331a46-7876-46de-b9f9-496fc3ff5870
rawhide <-> /dev/disk/by-id/dm-name-volgroup1-lvol0
NOTE: Function get_instance_id() is local helper function, which returns key
property of a class.
Thanks,
Peter Hatina
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/893/#review1240
-----------------------------------------------------------
Ship it!
Ship It!
cli/lmi/shell/LMIUtil.py
<http://reviewboard-openlmi.rhcloud.com/r/893/#comment779>
is it needed? since it seems local like the ref_list which is not requested
to be deleted, just overwritten.
- Ales Ledvinka
On Sept. 27, 2013, 11:12 a.m., Peter Hatina wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/893/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2013, 11:12 a.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-tools
>
>
> Description
> -------
>
> This patch introduces lmi_associators() function, which should speed up
> associations traversal by pulling all the instances referenced by association
> class.
>
>
> Diffs
> -----
>
> cli/lmi/shell/LMIConsole.py bebcce353c9547a9d7ed1c5f0031319e1876b29a
> cli/lmi/shell/LMIUtil.py 94f38b4ffedc286e3ac407085b66ad278ed1bcda
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/893/diff/
>
>
> Testing
> -------
>
> Example of usage:
>
> c = connect(...)
>
> assoc_class_list = [
> c.root.cimv2.CIM_BasedOn,
> c.root.cimv2.LMI_PhysicalMemoryContainer,
> c.root.cimv2.LMI_SystemStorageDevice,
> ]
>
> for tpl in lmi_associators(assoc_class_list):
> print " <-> ".join([get_instance_id(x) for x in tpl])
>
> Output:
>
> /dev/disk/by-uuid/fc6b795d-8722-4222-9252-3cfb3b704dd3 <-> /dev/vda
> /dev/disk/by-uuid/09331a46-7876-46de-b9f9-496fc3ff5870 <-> /dev/vda
> /dev/disk/by-id/dm-name-volgroup1-lvol0 <->
> /dev/disk/by-id/ata-QEMU_HARDDISK_QM00005
> /dev/disk/by-id/dm-name-volgroup1-lvol0 <->
> /dev/disk/by-id/ata-QEMU_HARDDISK_QM00007
> LMI:LMI_MemoryPhysicalPackage:0 <-> LMI:LMI_PhysicalMemory:0
> rawhide <-> /dev/disk/by-id/ata-QEMU_HARDDISK_QM00005
> rawhide <-> /dev/disk/by-id/ata-QEMU_HARDDISK_QM00007
> rawhide <-> /dev/vda
> rawhide <-> /dev/disk/by-uuid/fc6b795d-8722-4222-9252-3cfb3b704dd3
> rawhide <-> /dev/disk/by-uuid/09331a46-7876-46de-b9f9-496fc3ff5870
> rawhide <-> /dev/disk/by-id/dm-name-volgroup1-lvol0
>
> NOTE: Function get_instance_id() is local helper function, which returns key
> property of a class.
>
>
> Thanks,
>
> Peter Hatina
>
>
--- End Message ---
_______________________________________________
openlmi-reviews mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
_______________________________________________
openlmi-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/openlmi-devel
