Send openlmi-reviews mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of openlmi-reviews digest..."
Today's Topics:
1. Review Request 1002: openlmi-networking [1/1] Display
connection type of IPAssignmentSettingData and allow to change it
(Radek Novacek)
2. Re: Review Request 994: realmd: Fix unchecked result
(=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=)
3. buildbot failure in OpenLMI on providers-rhel7
([email protected])
4. Re: Review Request 1002: openlmi-networking [1/1] Display
connection type of IPAssignmentSettingData and allow to change it
(Jan Safranek)
5. Re: Review Request 1002: openlmi-networking [1/1] Display
connection type of IPAssignmentSettingData and allow to change it
(Radek Novacek)
6. buildbot failure in OpenLMI on networking-rhel7
([email protected])
7. Review Request 1003: openlmi-networking [1/1] Version 0.2.0
(Radek Novacek)
8. buildbot failure in OpenLMI on storage-rhel7
([email protected])
9. buildbot failure in OpenLMI on providers-rhel7
([email protected])
10. buildbot failure in OpenLMI on networking-rhel7
([email protected])
11. Re: Review Request 1003: openlmi-networking [1/1] Version
0.2.0 (Michal Minar)
12. Re: Review Request 1003: openlmi-networking [1/1] Version
0.2.0 (Radek Novacek)
13. buildbot failure in OpenLMI on storage-rawhide
([email protected])
14. buildbot failure in OpenLMI on providers-rawhide
([email protected])
15. buildbot failure in OpenLMI on networking-rawhide
([email protected])
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1002/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Display connection type of IPAssignmentSettingData and allow to change it
Getting connection type (DHCP, Static, etc.) for existing connection was
not easy - user must check types of associated classes. This change
introduces two new properties of IPAssignmentSettingData class -
IPv4Type and IPv6Type - same as the LMI_CreateIPSetting method
paramaters.
This also allow to change the type of the connection by changing values
of these two properties.
This resolves following RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1011903
Diffs
-----
mof/60_LMI_Networking.mof b4bd1912717aa3ddb0381fa7bba57d03c0fd2836
src/LMI_IPAssignmentSettingDataProvider.c
70fbc95eb63f1b7b506b5c6c8dc1c5f2a28ee5a2
src/ipassignmentsettingdata.c 56bc01d1f03d7eb0d0ba9ac6f40e4ae34950a1fb
test/test_modify_connection.py e560ac1c098f8ed9442f1a3c24c69ca79008740d
Diff: http://reviewboard-openlmi.rhcloud.com/r/1002/diff/
Testing
-------
Thanks,
Radek Novacek
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/994/
-----------------------------------------------------------
(Updated Oct. 14, 2013, 12:15 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
realmd: Fix unchecked result
Found by Coverity Scan. The change is really not needed, the iter variable
is initialized NULL and subsequent g_variant_iter_next() call should return
immediately, preventing the cycle to run.
But, just to be on a safe side...
--
This is CID 11850 in Coverity
Diffs
-----
src/realmd/LMI_RealmdServiceProvider.c
bd713b8a96e25addb88ccf9e12d8cf54bcf0f5cb
Diff: http://reviewboard-openlmi.rhcloud.com/r/994/diff/
Testing
-------
Thanks,
Tomáš Bžatek
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder providers-rhel7 while
building providers.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/providers-rhel7/builds/100
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rhel7-slave
Build Reason: scheduler
Build Source Stamp: [branch master] 7584e2fb80a74b7e4db3b653937a2c6ee64a7400
Blamelist: Tomas Bzatek <[email protected]>
BUILD FAILED: failed tests selinux check
sincerely,
-The Buildbot
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1002/#review1419
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On Oct. 14, 2013, 2:12 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1002/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2013, 2:12 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> Display connection type of IPAssignmentSettingData and allow to change it
>
> Getting connection type (DHCP, Static, etc.) for existing connection was
> not easy - user must check types of associated classes. This change
> introduces two new properties of IPAssignmentSettingData class -
> IPv4Type and IPv6Type - same as the LMI_CreateIPSetting method
> paramaters.
>
> This also allow to change the type of the connection by changing values
> of these two properties.
>
> This resolves following RFE:
> https://bugzilla.redhat.com/show_bug.cgi?id=1011903
>
>
> Diffs
> -----
>
> mof/60_LMI_Networking.mof b4bd1912717aa3ddb0381fa7bba57d03c0fd2836
> src/LMI_IPAssignmentSettingDataProvider.c
> 70fbc95eb63f1b7b506b5c6c8dc1c5f2a28ee5a2
> src/ipassignmentsettingdata.c 56bc01d1f03d7eb0d0ba9ac6f40e4ae34950a1fb
> test/test_modify_connection.py e560ac1c098f8ed9442f1a3c24c69ca79008740d
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1002/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1002/
-----------------------------------------------------------
(Updated Oct. 14, 2013, 2:32 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Display connection type of IPAssignmentSettingData and allow to change it
Getting connection type (DHCP, Static, etc.) for existing connection was
not easy - user must check types of associated classes. This change
introduces two new properties of IPAssignmentSettingData class -
IPv4Type and IPv6Type - same as the LMI_CreateIPSetting method
paramaters.
This also allow to change the type of the connection by changing values
of these two properties.
This resolves following RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1011903
Diffs
-----
mof/60_LMI_Networking.mof b4bd1912717aa3ddb0381fa7bba57d03c0fd2836
src/LMI_IPAssignmentSettingDataProvider.c
70fbc95eb63f1b7b506b5c6c8dc1c5f2a28ee5a2
src/ipassignmentsettingdata.c 56bc01d1f03d7eb0d0ba9ac6f40e4ae34950a1fb
test/test_modify_connection.py e560ac1c098f8ed9442f1a3c24c69ca79008740d
Diff: http://reviewboard-openlmi.rhcloud.com/r/1002/diff/
Testing
-------
Thanks,
Radek Novacek
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder networking-rhel7 while
building networking.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/networking-rhel7/builds/64
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rhel7-slave
Build Reason: scheduler
Build Source Stamp: [branch master] abb58a097bc49d21bb406ee23bd6970ea1675836
Blamelist: Radek Novacek <[email protected]>
BUILD FAILED: failed tests selinux check
sincerely,
-The Buildbot
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1003/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Version 0.2.0
Diffs
-----
CMakeLists.txt 65edcda6565aaf46236eec3c59eb06b9dbef2e7c
openlmi-networking.spec c07f1496c74e0a0a30cf72641bfecdadd640f4bf
Diff: http://reviewboard-openlmi.rhcloud.com/r/1003/diff/
Testing
-------
Thanks,
Radek Novacek
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder storage-rhel7 while
building OpenLMI.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/storage-rhel7/builds/73
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rhel7-slave
Build Reason: The Nightly scheduler named 'storage nightly' triggered this build
Build Source Stamp: [branch master] HEAD
Blamelist:
BUILD FAILED: failed selinux check
sincerely,
-The Buildbot
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder providers-rhel7 while
building OpenLMI.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/providers-rhel7/builds/101
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rhel7-slave
Build Reason: The Nightly scheduler named 'providers nightly' triggered this
build
Build Source Stamp: [branch master] HEAD
Blamelist:
BUILD FAILED: failed tests selinux check
sincerely,
-The Buildbot
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder networking-rhel7 while
building OpenLMI.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/networking-rhel7/builds/65
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rhel7-slave
Build Reason: The Nightly scheduler named 'networking nightly' triggered this
build
Build Source Stamp: [branch master] HEAD
Blamelist:
BUILD FAILED: failed tests selinux check
sincerely,
-The Buildbot
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1003/#review1420
-----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Oct. 14, 2013, 12:48 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1003/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2013, 12:48 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> Version 0.2.0
>
>
> Diffs
> -----
>
> CMakeLists.txt 65edcda6565aaf46236eec3c59eb06b9dbef2e7c
> openlmi-networking.spec c07f1496c74e0a0a30cf72641bfecdadd640f4bf
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1003/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
--- End Message ---
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1003/
-----------------------------------------------------------
(Updated Oct. 15, 2013, 8:41 a.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Version 0.2.0
Diffs
-----
CMakeLists.txt 65edcda6565aaf46236eec3c59eb06b9dbef2e7c
openlmi-networking.spec c07f1496c74e0a0a30cf72641bfecdadd640f4bf
Diff: http://reviewboard-openlmi.rhcloud.com/r/1003/diff/
Testing
-------
Thanks,
Radek Novacek
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder storage-rawhide while
building storage.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/storage-rawhide/builds/90
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rawhide-slave
Build Reason: scheduler
Build Source Stamp: [branch master] f15b90fdf6765002a977fe826162e5cbbdcea38c
Blamelist: Jan Synacek <[email protected]>
BUILD FAILED: failed tests selinux check
sincerely,
-The Buildbot
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder providers-rawhide while
building OpenLMI.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/providers-rawhide/builds/120
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rawhide-slave
Build Reason: The Nightly scheduler named 'providers nightly' triggered this
build
Build Source Stamp: [branch master] HEAD
Blamelist:
BUILD FAILED: failed tests selinux check
sincerely,
-The Buildbot
--- End Message ---
--- Begin Message ---
The Buildbot has detected a failed build on builder networking-rawhide while
building OpenLMI.
Full details are available at:
http://openlmi-rnovacek.rhcloud.com/builders/networking-rawhide/builds/97
Buildbot URL: http://openlmi-rnovacek.rhcloud.com/
Buildslave for this Build: rawhide-slave
Build Reason: The Nightly scheduler named 'networking nightly' triggered this
build
Build Source Stamp: [branch master] HEAD
Blamelist:
BUILD FAILED: failed tests selinux check
sincerely,
-The Buildbot
--- End Message ---
_______________________________________________
openlmi-reviews mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
_______________________________________________
openlmi-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/openlmi-devel
