Review: Approve + if type(icon) is QtGui.QIcon: + elif type(icon) is types.StringType or type(icon) is types.UnicodeType:
I think the Right Way is isinstance(). Also, "basestring" matches both str and unicode strings. if isinstance(icon, QtGui.QIcon): elif isinstance(icon, basestring): review approve -- https://code.launchpad.net/~trb143/openlp/servicing/+merge/6134 Your team openlp.org Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
