Review: Approve
Pluggable slide controllers? How are they "pluggable"?

Is there not a better, more OS-agnostic, way of doing this?

439     +    def checkOoPid(self):
440     +        if os.name == u'nt':
441     +            import win32api
442     +            handle = win32api.OpenProcess(PROCESS_TERMINATE, False, 
self.oopid)
443     +            #todo need some code here
444     +            return True
445     +        elif os.name == u'mac':
446     +            pass
447     +        else:
448     +            procfile = open("/proc/%d/stat" %(self.oopid))
449     +            file = procfile.readline().split()[1]
450     +            print file
451     +            if file == u'(soffice)' or file == u'(openoffice.org)':
452     +                return True
453     +            return False
-- 
https://code.launchpad.net/~trb143/openlp/servicing2/+merge/7960
Your team openlp.org Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to