Review: Approve
I can't comment on much of the code, not familiar with sqlalchemy, but while
I'm here...
Niggles:
420 + osis = codecs.open(osisfile_record, u'r', details['encoding'])
Is there a reason 'encoding' shouldn't be unicode?
1088 +mapper(ONTestament, testament_table,
1089 + properties={'books': relation(Book, backref='testament')})
1090 +mapper(Book, book_table,
1091 + properties={'verses': relation(Verse, backref='book')})
More unicode strings?
--
https://code.launchpad.net/~raoul-snyman/openlp/biblefixes/+merge/8841
Your team openlp.org Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
