> +from songmaintenanceform import SongMaintenanceForm > > Imports should always be absolute (unless there's a good reason not to). I see > there are already some relative imports though.
I'll do this in the next merge. > + if self.LastNameEdit.text() != u'': > > I'd use 'if not self.LastNameEdit.text()', since that will handle it being > None or a bytestring. I'll have to test this out, I'm not sure it'll work with PyQt... AFAIK QLineEdits always return a string. > I'm not a fan of commented out code (bottom of authorsform.py) since you can > always get the old code anyway (yay for version control ;-) ). Oops, I did mean to remove that! -- https://code.launchpad.net/~raoul-snyman/openlp/songmaintenance/+merge/9264 Your team openlp.org Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
