Review: Approve Looks good! One thought - if we are only ever going to be bold/not bold (ie not providing a UI for numerical weights) it would probably be better for the xml and the theme object to carry a boolean property called "bold" and just set the weight based on that.
Then if someone decides that 75 is not heavy enough, it's only a single change. One more thing: 10 + int(self._theme.font_footer_weight), # weight 11 + 0)# italic 12 + self.footerFont.setItalic(int(self._theme.font_footer_italics)) Is there a reason you can't set the italic with the same fn call as the weight (Line 11 even has a comment implying it can)... -- https://code.launchpad.net/~trb143/openlp/bugfixes/+merge/9546 Your team openlp.org Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
