Review: Approve I'll approve this, but there are two things I spotted: 1. I think the "sender" attribute should come _before_ the event type, then event_type can default to EventType.Default.
2. My idea was that the "sender" attribute would be a reference to an _object_, not a _string_ of the object name. This way the event receiver can interact with the event sender if necessary. -- https://code.launchpad.net/~trb143/openlp/bugfixes/+merge/10042 Your team openlp.org Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
