Review: Approve
Looks much better thanks. Just two comments...
1. When wanting to construct a string, rather use string formatting, like so:
u':' +self.IconPath+u'_new.png'
becomes
u':%s_new.png' % self.IconPath
2. Can we rather use Firefox's agent string, or make up a better one than IE
5.5 ? Also, I
think urllib/urllib2 might have a default agent string, which might be
better.
--
https://code.launchpad.net/~trb143/openlp/bitsandbobs/+merge/13200
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
