Review: Needs Fixing
Duel screen eh? I'd better beware that my monitors are standing far apart and 
without lances so that they can't duel!

Some issues that need to be resolved first though:

    screens = Screen()

If ``screens`` is supposed to be a list of screens, rather call ``Screen`` 
``ScreenList`` - less possibility of confusion.

Um, why??? You're doing exactly the same thing.

    if isinstance(image, QtGui.QImage):
        preview = QtGui.QImage(image)
    else:
        preview = QtGui.QImage(image)

Is there still a need for this?

    char_per_line = line_width / metrics.width(u'i')

-- 
https://code.launchpad.net/~trb143/openlp/working/+merge/17909
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to