Review: Needs Fixing
27      + def icon_from_file(self, file, thumb):

This is part of a Qt class, should be:

27      + def iconFromFile(self, file, thumb):


91      + return None
92      \ No newline at end of file

There should always be at least 1 open line at the end of every file, and if 
you have a class, it should be 2 lines.



-- 
https://code.launchpad.net/~trb143/openlp/bugs1/+merge/22903
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to