Review: Needs Fixing
Didn't see this the last time, because I didn't approve your proposal the last
time.
def get_200_ok(self, mimetype='text/html; charset="utf-8"'):
Please can you change that to
def GET_200_OK(....)
or
def GET_200_response(....)
"GET" is an HTTP keyword, and if it's not in capitals in the Python class, it
looks like a "getter", which can lead to confusion.
P.S. I'm going to clean and fix your broken HTML and make it prettier and make
the JS better.
--
https://code.launchpad.net/~j-corwin/openlp/remote/+merge/24663
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
