Review: Needs Fixing I agree with Tim, we shouldn't use "getter" methods, the variable is right there. In fact, you're using the get_display_name() over the MediaItem's title, which I think should be translatable itself.
As I mentioned previously in IRC, we should rather set a self.display_name variable in the constructor of the plugin, and make it translatable right there. You have the right idea, we just need to implement it in a different way. -- https://code.launchpad.net/~crichter/openlp/i18n/+merge/26126 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
