On Wed, Jul 07, 2010 at 09:11:41PM -0000 or thereabouts, Jonathan Corwin wrote: > And also also... it didn't strip out "---" and "-!!" page break/column break > markers.
Ahh, do they apply to songs. Hadn;t realised that - I'll stick a testcase in. I'd rather keep the tests in trunk (at least for now, as it's a quick way to know I haven;t broken anything previously working :) > The CCLI number wasn't imported Hmm. Should have been, but maybe your other note about ccli nos is significant! > The song <theme>'s didn't get imported as Topics. Ahh. I seem to have found a "theme" item to set it to (from somewhere - possibly the old opensong import code) rather than using Topic, Sorry! > And this might be just the SongImport class falling behind on other verse > order changes, but the chorus was created with ---[Chorus:]--- rather than > ---[Chorus:1]--- Righto > This meant I couldn't edit the imported song, and save it without getting a > verse order error. Thanks for all those (and the others - I'll have a dig at them...) Cheers, Martin -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/29420 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
