Review: Needs Fixing
You're breaking the abstraction adding those DB mappings.  You should be using 
topics = song.topics and for topic in topics, etc.  All the info is already 
there.

if new_author in song.authors
if new_topic in song.topics
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/30179
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to