Review: Needs Fixing 910 + if expand == None: 911 + expand = self.expandTabs 912 log.debug(u'addServiceItem') 913 if expand == None: 914 expand = self.expandTabs
I don't get that. Firstly, you're using == with None where you should use "is"; secondly, What other values can "expand" be such that "self.expandTabs" which is a boolean can be set to? themedialog.py: * needs our standard copyright * should be named "themewizard.py" * has wrapping issues * doesn't use our translate() function -- https://code.launchpad.net/~trb143/openlp/alpha4/+merge/41203 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
