Review: Needs Fixing
169     + if not os.path.exists(dir):
170     + os.mkdir(dir)

You need to use os.makedirs(), not os.mkdir().

530     + self.tagTableWidget.horizontalHeaderItem(0). \
531     +     setText(translate('OpenLP.DisplayTagTab', 'Description'))
532     + self.tagTableWidget.horizontalHeaderItem(1). \
533     +     setText(translate('OpenLP.DisplayTagTab', 'Tag id'))
534     + self.tagTableWidget.horizontalHeaderItem(2). \
535     +     setText(translate('OpenLP.DisplayTagTab', 'Start Html'))
536     + self.tagTableWidget.horizontalHeaderItem(3). \
537     +     setText(translate('OpenLP.DisplayTagTab', 'End Html'))

Move the . to the next line (``.setText``) and put the \ right next to the 
closing bracket.

793     + displayTagTab = DisplayTagTab()
794     + self.addTab(u'Display Tags', displayTagTab)

Shouldn't that be ``self.displayTagTab = DisplayTagTab()`` like the previous 
tabs?

-- 
https://code.launchpad.net/~trb143/openlp/next/+merge/45632
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to