Review: Needs Information
How on earth did you set up a scenario in which you didn't have kwargs? If you
have that scenario you have no files to import from and therefore no
import_source, you've no business carrying on an importer under those
circumstances.
Assuming it's possible to get as far as your if statement it should be:
if kwargs:
else:
raise alarmBells # move this else: raise from the inner if to the outer.
But I don't think that if should be necessary as none of the imports should be
failing to pass an import source.
--
https://code.launchpad.net/~j-corwin/openlp/general/+merge/52938
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
