Review: Needs Fixing Line 8 looks iffy onPreviewAddToService will not work as you cannot guarantee the preview and selected items are the same. The SlideController has the service item so why not call self.parent.liveController.addServiceItem(Item)
Line 93 space after comma. Default value should be None not "*". setAutoSelectItem should be moved to mediamanageritem Just Initialise self.autoSelectItem to none and not bother calling the method then you would not need the default to be set. -- https://code.launchpad.net/~smpettit/openlp/custom/+merge/61696 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
