Review: Needs Fixing
101     + self.parent = plugin.formparent

Use self.setParent() or instantiate the form properly by passing the parent to 
the form. The line above removes the Qt methond "parent()" and replaces it with 
the variable.

Everything else looks fine.
-- 
https://code.launchpad.net/~j-corwin/openlp/general/+merge/62760
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to