Review: Needs Fixing
17      + log.exception(u'No verses found to import for book '
18      + u'"%s"', book)

Do not use log.exception() for anything other than when you're catching an 
exception. Rather use log.error() for errors, or log.warn() for non-fatal 
errors. In this case, you should use log.warn.
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/63218
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to