Review: Needs Fixing single letter variable names should be more meaningful. The Regex should be at the top of the file so compiled once and name in CAPITALS.
Lines should be 80 bytes and some lines look long! 41 extra space 60 not needed blank line 64 need spaces 66 u'1' -- https://code.launchpad.net/~karan85/openlp/ewimport-fix/+merge/66842 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
