Review: Needs Fixing Sorry, for not saying/noticing this in the last review. Lines 40/44: There should not be a space between the string and the colon. A few lines later (not in the diff) we have some code to display the playing time. This should be moved on modified to work in the same way as the changes already in the diff. (Unless it will be possible to have move audio/video files in one item soon. ;-) )
Rest looks good. I am particular happy that you fixed the theme update thing (I guess many people were confused when they were testing things). -- https://code.launchpad.net/~trb143/openlp/fbeta3/+merge/67445 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
