Review: Needs Fixing
You need to add the dependency to the scripts/check_dependencies.py. And do not 
forget the mail to the mailing list about the new dependency.

Please add docstrings to upgrade_1. It would be good if we document the 
"database history" and when we changed things.
-- 
https://code.launchpad.net/~raoul-snyman/openlp/db-upgrades/+merge/72916
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to