Review: Needs Fixing

Please rename the signal and document it in the eventreceiver. I am not sure 
myself about the name. However, first of all we should append a "d": 
"css_updated"
Better would be "maindisplay_css_updated" or just "display_css_updated". As far 
as I remember maindisplay refers to the live screen, but this signal would also 
affect the other screens, so maybe we should say that maindisplay means the 
live screen and display any screen. Anyway, just my thoughts. We probably need 
to be discussed this.

Some docstrings are missing. Sorry for bothering you with this, but I always 
have the intention to document any method and function.
-- 
https://code.launchpad.net/~trb143/openlp/plugin-changes/+merge/79489
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to