Review: Approve 18 if plugin.status is not PluginStatus.Disabled: 19 plugin.settings_tab = plugin.getSettingsTab(settings_form)
Looking at this piece of code, I honestly don't know what we were thinking when we wrote it. Why do we need to manually assign that, why doesn't getSettingsTab() do that itself? Probably rename it to createSettingsTab() in the process... But that's not your code, and everything else looks fine to me. -- https://code.launchpad.net/~trb143/openlp/bug-versions/+merge/84365 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
