Review: Needs Fixing Whilst I can see what you are doing I would like the code restructured. The V1 code was kept in it's own method for a reason (it will die at some point) and I did not want that mixed too much with V2. Lines 119 - 146 should be in there own method.
Why remove file_is_unicode and then add the code twice. If the method is wrong fix it not duplicate the code. I may have missed the discussions on IRC so I may be wrong about this. -- https://code.launchpad.net/~m2j/openlp/work/+merge/85413 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
