> Instead creating the BibleStrings class you could create a dict. If I > interprete it right, in line 231 a whole instance of BibleStrings is created > over and over again just to take one value. > With one (in openlp/plugins/bibles/lib/__init__.py) you need not more than one > instance, and you do not have to make such replacements(184ff, 228ff), as keys > in docts may contain any string.
Thanks for your opinion, I'll change that. A dict is the better way. I've found a bug by myself too. There is no need to review at the moment. I'll fix them. -- https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/95156 Your team OpenLP Core is requested to review the proposed merge of lp:~orangeshirt/openlp/bibles into lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
