Review: Needs Fixing
if ret == QtGui.QMessageBox.Yes:
return True
elif ret == QtGui.QMessageBox.No:
return False
Can be replaced with:
return ret == QtGui.QMessageBox.Yes
What changed between lines 29 and 30? Please make sure you're using UNIX/Linux
line endings.
There's actually no need for brackets around the returned params on line 39.
Please use words_separated_by_underscores, as per PEP8.
Wordsthatarechainedtogetherarehardtoreadandunderstand.
You also don't need brackets around all the things you are returning.
--
https://code.launchpad.net/~phill-ridout/openlp/overwrite/+merge/96844
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
