Hi Sam, Thinking about it further, this would be the wrong place to strip invalid chars such as tabs. Ideally this should be done by the code that commits the data to the database. This is common to the importers, as well as the song edit form and the reindexer.
If your code works fine, I have no problem with it, im not sure what the other guys think, but I dont think it is necessary to do a rewrite, unless you want to! Phill On Apr 30, 2012 10:19 PM, "Samuel Findlay" <[email protected]> wrote: > Though still makes sense to replace tab with space, as you suggest. > On May 1, 2012 7:15 AM, "Samuel Findlay" <[email protected]> wrote: > > > You're right Phill, the non-printing bytes do specify the length of the > > following field/label. A rewrite based on this info should be more > > efficient. > > > > This may also avoid the need for stripping ascii control characters. > > On May 1, 2012 1:13 AM, "phill" <[email protected]> wrote: > > > >> One more thing, lines 223 - 229: the "non-printing byte" specifies how > >> many > >> chars (or bytes) long the "label" is. It is not unique to the label, > i.e. > >> If you had two labels the same length, the would have the same > >> non-printing > >> byte ay the start. > >> > >> Phill > >> > >> -- > >> > >> > https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104102 > >> You are the owner of lp:~sfindlay/openlp/songs-import-powersong. > >> > > > > -- > > https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104102 > You are subscribed to branch lp:openlp. > -- https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104102 Your team OpenLP Core is requested to review the proposed merge of lp:~sfindlay/openlp/songs-import-powersong into lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
