Review: Needs Fixing I'm not too keen on refactors/tidies at this stage, it's all too easy to introduce mistakes or miss a variable. However this time I will let it pass. Although wondering what verseId on line 162 did to upset you :)
Needs fixing for: Rather than splitting the title if it contains any \n's (which will cause a blank title if there is a leading blank line), how about replacing them with a space and left trimming? -- https://code.launchpad.net/~googol/openlp/trivial/+merge/110662 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
