Review: Needs Information

Why did you moved the code to the _set_text_rectangle method? Why not in the 
constructor?

Line 43: Don't we always use %s instead of +?
-- 
https://code.launchpad.net/~j-corwin/openlp/bug-1016843/+merge/112229
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to