Review: Needs Information I am not sure about line 9. I do not see a place where previous_raw becomes None.
My question: Why did you change the line? In what circumstances does this fix or prevent something? Currently I believe that this check is not needed any longer (because it is always true). Just check the code yourself: previous_raw is set to u'' or is build from strings, but never set to None. -- https://code.launchpad.net/~phill-ridout/openlp/bug-1011286/+merge/116168 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
