Review: Needs Fixing
74 + from openlp.plugins.bibles.lib import LanguageSelection, \
75 + BibleStrings
Is there a particular reason you couldn't put this at the top of the file?
79 + for character in u'\\.^$*+?{}[]()':
I know this isn't your code, but could you please just make the string literal
here a "constant"? i.e.
RESERVED_CHARACTERS = u'\\.^$*+?{}[]()'
...
for character in RESERVED_CHARACTERS:
--
https://code.launchpad.net/~erik-lundin/openlp/bug-1053654/+merge/128580
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
